RemovedHighlight of Weekly #001
Dead YouTube editor plugin removed
YoutubePlugin was never registered and called a route that does not exist. Pasting a YouTube URL still works through VideoPlugin. Remove any custom code that imports YoutubePlugin or YOUTUBE_URL_GET_VIDEO_ID.
AppFramework & technical, Website
On the upgrade checklist: 19.0 → 20.0
Pull requests and commits
Commit message
[REM] html_editor, website: youtube plugin
YoutubePlugin is dead code.
- it is never added to any plugin list. Its only reference outside its own file
is website_builder.js, naming it as a string in the list of plugins removed in
translation mode.
- getYoutubeVideoElement awaits /html_editor/video_url/data, a route that exists
nowhere in the codebase, so the rpc would reject before createVideoElement is
ever reached.
Its exported YOUTUBE_URL_GET_VIDEO_ID regex has no consumer either.
Pasting a Youtube url still offers a powerbox command through
VideoPlugin.getCommandForVideoUrlPaste, which iterates PLATFORMS and
therefore covers Youtube.
task-6466707